[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/22017 )
Change subject: IMPALA-9170 close idle connections without an associated session ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22017/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/22017/1/be/src/service/impala-server.cc@2648 PS1, Line 2648: if (it == connection_to_sessions_map_.end()) return true; > Joe had encountered this elsewhere and recommended using TCP keepalive (IMP Thanks! You're right. I agree that it might be too aggressive. It is more related to IMPALA-13253. KEEPALIVE option may be turned on when creating socket. (https://github.com/apache/impala/blob/branch-4.4.1/be/src/rpc/thrift-server.cc#L326-L353) I reproduced the same situation and tried libkeepalive and impala coordinator cleaned up connections. -- To view, visit http://gerrit.cloudera.org:8080/22017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I359b0e0e90a7c6b32579234b1d88eb7ff27725d3 Gerrit-Change-Number: 22017 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 05 Nov 2024 04:53:24 +0000 Gerrit-HasComments: Yes
