Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22006 )
Change subject: IMPALA-13503: CustomClusterTestSuite for whole class ...................................................................... Patch Set 7: > > Patch Set 7: > > > > I like the idea of being able to reuse the cluster for the whole > class. I think that makes a lot of sense and could save us a bunch > of time. > > > > In the case of the tuple cache TPC-H/TPC-DS tests, the flags we > would add at startup would not interfere with other tests, because > enable_tuple_cache would still default to false. Tuple cache tests > can run as normal parallel end-to-end tests with enable_tuple_cache=true > while everything else is happening normally. That allows > parallelism that I think this approach would not allow. (But I need > to file a JIRA about turning that on for precommit or on by > default.) > > Good point. Would it make sense to always set TUPLE_CACHE_DIR in > dev environment so the query tests are run regularly? I had been planning to have it enabled for precommit. I think it makes sense in the dev environment too. We'll want to be careful about disk space, but I think defaulting to having tuple cache available would keep things simpler. I'll file a JIRA to get this going. -- To view, visit http://gerrit.cloudera.org:8080/22006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a08694edcf8cc340d89a0fb33beb8229163b356 Gerrit-Change-Number: 22006 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 05 Nov 2024 22:28:56 +0000 Gerrit-HasComments: No
