Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22006 )
Change subject: IMPALA-13503: CustomClusterTestSuite for whole class ...................................................................... Patch Set 7: (3 comments) Thanks, this is really a good idea. http://gerrit.cloudera.org:8080/#/c/22006/7/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22006/7/tests/common/custom_cluster_test_suite.py@45 PS7, Line 45: method Could add something like "as opposed to [a class|the whole class]". http://gerrit.cloudera.org:8080/#/c/22006/7/tests/common/custom_cluster_test_suite.py@91 PS7, Line 91: Every test in a test suite deriving from this class gets its own Impala cluster. Although the added sentence clarifies this, I think this sentence is a bit misleading now. This class comment could start by describing that there are two modes: one where each test has its own cluster and the other where the class has one. http://gerrit.cloudera.org:8080/#/c/22006/7/tests/custom_cluster/test_tuple_cache.py File tests/custom_cluster/test_tuple_cache.py: http://gerrit.cloudera.org:8080/#/c/22006/7/tests/custom_cluster/test_tuple_cache.py@684 PS7, Line 684: entries_in_use Nit: could call it 'new_entries_in_use'. -- To view, visit http://gerrit.cloudera.org:8080/22006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a08694edcf8cc340d89a0fb33beb8229163b356 Gerrit-Change-Number: 22006 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 06 Nov 2024 12:16:07 +0000 Gerrit-HasComments: Yes
