Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21869 )
Change subject: IMPALA-11265: Part2: Store Iceberg file descriptors in encoded format ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21869/2/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java File fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java: http://gerrit.cloudera.org:8080/#/c/21869/2/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@83 PS2, Line 83: public boolean equals(Object obj) { Wouldn't it make sense to include the equals() and hashCode() overrides in the definition of FileDescriptor, instead of using a subclass here? http://gerrit.cloudera.org:8080/#/c/21869/2/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@205 PS2, Line 205: pathHashAndFd This could be a local variable in the loops below, I think it's good to limit the scope of variables. -- To view, visit http://gerrit.cloudera.org:8080/21869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d7794df999bdaf118158eace26cea610f911c0a Gerrit-Change-Number: 21869 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 07 Nov 2024 10:34:48 +0000 Gerrit-HasComments: Yes
