Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21309 )
Change subject: IMPALA-12046: Add profile counter for scan range queueing time on disk queues ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/21309/4/be/src/util/stopwatch.h File be/src/util/stopwatch.h: http://gerrit.cloudera.org:8080/#/c/21309/4/be/src/util/stopwatch.h@282 PS4, Line 282: , "Reset" It seems we don't need Reset() here. http://gerrit.cloudera.org:8080/#/c/21309/4/tests/custom_cluster/test_disk_io_queue.py File tests/custom_cluster/test_disk_io_queue.py: http://gerrit.cloudera.org:8080/#/c/21309/4/tests/custom_cluster/test_disk_io_queue.py@39 PS4, Line 39: query = "select * from functional.alltypes limit {0}".format(num_rows) Can we add test for the case when data_cache is enabled and used by concurrent queries? I'm doing a perf test on S3 with data_cache and concurrent queries so I tested this patch by the way. It seems the counter value is too high: - DecompressionTime: 1s209ms - MaterializeTupleTime: 4s505ms - ScannerIoWaitTime: 1s985ms - TotalDiskIoQueueTime: 7s039ms - TotalRawHdfsOpenFileTime: 0.000ns - TotalRawHdfsReadTime: 267.996ms - TotalTime: 8s486ms -- To view, visit http://gerrit.cloudera.org:8080/21309 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0cb24db36cd89933c150b88e166e68a3abc7a60 Gerrit-Change-Number: 21309 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 11 Nov 2024 23:56:15 +0000 Gerrit-HasComments: Yes
