Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21762 )
Change subject: IMPALA-13333: Limit memory estimation if PlanNode can spill ...................................................................... Patch Set 16: (3 comments) Thank you for the review! Please also help review the bottom-most patch of this stack if you have time. http://gerrit.cloudera.org:8080/#/c/21762/15/fe/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java File fe/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java: http://gerrit.cloudera.org:8080/#/c/21762/15/fe/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java@132 PS15, Line 132: public static void setUp() throws Exception { > The lines from here are mostly the same as in PlannerTestBase.setUpTestClus Done http://gerrit.cloudera.org:8080/#/c/21762/15/fe/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java@741 PS15, Line 741: s > Is there a reason for a Long literal? Nope. Removed Long literal. http://gerrit.cloudera.org:8080/#/c/21762/15/fe/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java@752 PS15, Line 752: runPlannerTestFile( : "tpcds_cpu_cost/tpcds-q64-mem_limit-10g", testDb, optsWithLimit, testOptions); : } > These are the same in all added tests, could extract it into a function. Th Done -- To view, visit http://gerrit.cloudera.org:8080/21762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I290c4e889d4ab9e921e356f0f55a9c8b11d0854e Gerrit-Change-Number: 21762 Gerrit-PatchSet: 16 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 13 Nov 2024 05:05:53 +0000 Gerrit-HasComments: Yes
