Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21762 )
Change subject: IMPALA-13333: Limit memory estimation if PlanNode can spill ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/21762/15/fe/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java File fe/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java: http://gerrit.cloudera.org:8080/#/c/21762/15/fe/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java@132 PS15, Line 132: TExecutorGroupSet group_set = new TExecutorGroupSet(); The lines from here are mostly the same as in PlannerTestBase.setUpTestCluster(). Couldn't we call that function instead, modifying it so that it also accepts a parameter for "exec_group_name_prefix"? http://gerrit.cloudera.org:8080/#/c/21762/15/fe/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java@741 PS15, Line 741: L Is there a reason for a Long literal? http://gerrit.cloudera.org:8080/#/c/21762/15/fe/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java@752 PS15, Line 752: TQueryOptions optsWithLimit = new TQueryOptions(options); : optsWithLimit.setMem_limit_executors(20 * ByteUnits.GIGABYTE); : optsWithLimit.setMem_limit_coordinators(20 * ByteUnits.GIGABYTE); These are the same in all added tests, could extract it into a function. The function could optionally take a MEM_LIMIT parameter too, to include that use case as well. -- To view, visit http://gerrit.cloudera.org:8080/21762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I290c4e889d4ab9e921e356f0f55a9c8b11d0854e Gerrit-Change-Number: 21762 Gerrit-PatchSet: 15 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 12 Nov 2024 15:51:03 +0000 Gerrit-HasComments: Yes
