Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22006 )
Change subject: IMPALA-13503: CustomClusterTestSuite for whole class ...................................................................... Patch Set 9: Code-Review+1 (1 comment) This looks OK. Please double check by running exhaustive custom cluster test run, if you have not done so. http://gerrit.cloudera.org:8080/#/c/22006/9/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22006/9/tests/common/custom_cluster_test_suite.py@435 PS9, Line 435: def _start_impala_cluster(cls, There are ClustomCluster test methods that calls this directly rather than using with_args decorator. git grep -n _start_impala_cluster tests/ Please double check that they're still running OK after this changes. -- To view, visit http://gerrit.cloudera.org:8080/22006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a08694edcf8cc340d89a0fb33beb8229163b356 Gerrit-Change-Number: 22006 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 13 Nov 2024 16:04:21 +0000 Gerrit-HasComments: Yes
