Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 25: Code-Review+1 (5 comments) http://gerrit.cloudera.org:8080/#/c/20447/24//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20447/24//COMMIT_MSG@40 PS24, Line 40: Testing: The patch is thouroughly tested and the tests are included in > Okay, will create jiras for them. Ack http://gerrit.cloudera.org:8080/#/c/20447/24/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20447/24/be/src/exprs/string-functions-ir.cc@1841 PS24, Line 1841: // encryption and decryption, and it can operate with various feedback sizes, offering > We can alter the number of feedback bits by using the FeedbackSize method. I'm not sure how anyone but a crypto expert would decide what the right value for FeedbackSize is. Without guidance here, I don't think it's actionable. I don't think it's critical to this patch however. http://gerrit.cloudera.org:8080/#/c/20447/25/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20447/25/be/src/exprs/string-functions-ir.cc@1813 PS25, Line 1813: // If a particular mode passed by user is not not supported then the default typo: "not not", don't need to repeat it. http://gerrit.cloudera.org:8080/#/c/20447/25/be/src/util/openssl-util-test.cc File be/src/util/openssl-util-test.cc: http://gerrit.cloudera.org:8080/#/c/20447/25/be/src/util/openssl-util-test.cc@91 PS25, Line 91: return; nit: I'd assert that Encrypt returns an error status. http://gerrit.cloudera.org:8080/#/c/20447/24/testdata/workloads/functional-query/queries/QueryTest/exprs.test File testdata/workloads/functional-query/queries/QueryTest/exprs.test: http://gerrit.cloudera.org:8080/#/c/20447/24/testdata/workloads/functional-query/queries/QueryTest/exprs.test@3291 PS24, Line 3291: # AES encryption/decryption examples: > nit: "encryption/decryption" fits our normal style better. Done -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 25 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Wed, 13 Nov 2024 23:34:07 +0000 Gerrit-HasComments: Yes
