Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 26: (3 comments) > Uploaded patch set 26. This patchset addresses log flooding issue and removes code duplication while initializing EncryptionKey. http://gerrit.cloudera.org:8080/#/c/20447/24/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20447/24/be/src/exprs/string-functions-ir.cc@1841 PS24, Line 1841: if (cipher_mode == AES_CIPHER_MODE::INVALID) { > I'm not sure how anyone but a crypto expert would decide what the right val Done http://gerrit.cloudera.org:8080/#/c/20447/25/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20447/25/be/src/exprs/string-functions-ir.cc@1813 PS25, Line 1813: if (expr.is_null) { > typo: "not not", don't need to repeat it. Done http://gerrit.cloudera.org:8080/#/c/20447/25/be/src/util/openssl-util-test.cc File be/src/util/openssl-util-test.cc: http://gerrit.cloudera.org:8080/#/c/20447/25/be/src/util/openssl-util-test.cc@91 PS25, Line 91: return; > nit: I'd assert that Encrypt returns an error status. Hi, as Daniel suggested, we can keep ECB encryption in developers' tests: https://gerrit.cloudera.org/c/20447/24/be/src/util/openssl-util-test.cc#67. -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 26 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Sat, 23 Nov 2024 05:43:18 +0000 Gerrit-HasComments: Yes
