Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async ...................................................................... Patch Set 9: (2 comments) will rebase in next patch, please hold off on reviewing it till then http://gerrit.cloudera.org:8080/#/c/10060/7/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/10060/7/be/src/service/impala-server.cc@663 PS7, Line 663: return Status::OK(); > Right, depends on the client. Maybe check to see if/how CM and Hue and any will update this once i get a definite response from both teams http://gerrit.cloudera.org:8080/#/c/10060/7/be/src/util/promise.h File be/src/util/promise.h: http://gerrit.cloudera.org:8080/#/c/10060/7/be/src/util/promise.h@77 PS7, Line 77: /// Set() is done and the promise is safe to delete. > Sure. I was thinking of something simpler just to refactor the code. But I' Done -- To view, visit http://gerrit.cloudera.org:8080/10060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf Gerrit-Change-Number: 10060 Gerrit-PatchSet: 9 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 18 May 2018 01:07:51 +0000 Gerrit-HasComments: Yes