Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10060 )

Change subject: IMPALA-5216: Make admission control queuing async
......................................................................


Patch Set 9:

> > (2 comments)
 > >
 > > will rebase in next patch, please hold off on reviewing it till
 > > then
 >
 > Please try to do rebases in independent patchsets though. It makes
 > looking at diffs of patchsets much easier to keep the rebases
 > separate.

Yup, thats exactly what I am doing :). Just wanted to hold off reviewing till 
then so that after rebase, I can highlight any conflict resolutions that might 
be important to the core changes in this patch.


--
To view, visit http://gerrit.cloudera.org:8080/10060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf
Gerrit-Change-Number: 10060
Gerrit-PatchSet: 9
Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 May 2018 01:33:52 +0000
Gerrit-HasComments: No

Reply via email to