Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21976 )
Change subject: IMPALA-13481: Add support for various agg and analytic functions ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/21976/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java: http://gerrit.cloudera.org:8080/#/c/21976/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@118 PS9, Line 118: * cume_dist() over([partition by clause] order by clause) > In Impala's documentation (https://impala.apache.org/docs/build/plain-html/ No, I blew it here. The code is pretty clear in Impala about what should be done (they have params copyOrderBy and reverseOrderBy for the newly created functions). We should not push this without a proper fix and I don't think it'll be too hard. I'll add the test cases for all 3 functions and change the documentation here once the code is complete. -- To view, visit http://gerrit.cloudera.org:8080/21976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57c69a60c63872b2964688f395b662a85698555e Gerrit-Change-Number: 21976 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 20 Nov 2024 01:03:44 +0000 Gerrit-HasComments: Yes
