Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21976 )
Change subject: IMPALA-13481: Add support for various agg and analytic functions ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/21976/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java: http://gerrit.cloudera.org:8080/#/c/21976/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RewriteRexOverRule.java@118 PS9, Line 118: * cume_dist() over([partition by clause] order by clause) > No, I blew it here. The code is pretty clear in Impala about what should b Latest patch should fix the order by desc issue. Also, a new desc test case has been added for the 3 functions. The ntile and percent_rank did not need to be changed because the order by clause is not reversed in that case as specified in AnalyticExpr.java. The Impala code has some more order by situations that are handled but are not in the test framework. These include when the order by column has multiple columns and if the null direction is changed. I filed issue IMPALA-13562 for this. -- To view, visit http://gerrit.cloudera.org:8080/21976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57c69a60c63872b2964688f395b662a85698555e Gerrit-Change-Number: 21976 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 21 Nov 2024 17:44:03 +0000 Gerrit-HasComments: Yes
