Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10449 )
Change subject: IMPALA_7011: Simplify PlanRootSink control logic ...................................................................... Patch Set 3: Code-Review+1 (5 comments) http://gerrit.cloudera.org:8080/#/c/10449/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10449/3//COMMIT_MSG@7 PS3, Line 7: IMPALA_7011 nit: IMPALA-7011 http://gerrit.cloudera.org:8080/#/c/10449/3//COMMIT_MSG@20 PS3, Line 20: control nit: controlled http://gerrit.cloudera.org:8080/#/c/10449/3//COMMIT_MSG@24 PS3, Line 24: to nit: extra word? http://gerrit.cloudera.org:8080/#/c/10449/3/be/src/exec/plan-root-sink.h File be/src/exec/plan-root-sink.h: http://gerrit.cloudera.org:8080/#/c/10449/3/be/src/exec/plan-root-sink.h@107 PS3, Line 107: MORE_ROWS nit: how about ROWS_PENDING http://gerrit.cloudera.org:8080/#/c/10449/3/be/src/exec/plan-root-sink.cc File be/src/exec/plan-root-sink.cc: http://gerrit.cloudera.org:8080/#/c/10449/3/be/src/exec/plan-root-sink.cc@a76 PS3, Line 76: just curious, was this dead code all along or is there ever a possibility of passing a null batch to Send()(granted that would crash at L67 anyway or at L73 on a release build)? -- To view, visit http://gerrit.cloudera.org:8080/10449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc75617a253fd43a6122baa4b4dc7aeb1dbe633f Gerrit-Change-Number: 10449 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 18 May 2018 18:29:07 +0000 Gerrit-HasComments: Yes
