Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10449 )

Change subject: IMPALA_7011: Simplify PlanRootSink control logic
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/10449/3/be/src/exec/plan-root-sink.h
File be/src/exec/plan-root-sink.h:

http://gerrit.cloudera.org:8080/#/c/10449/3/be/src/exec/plan-root-sink.h@57
PS3, Line 57: respecively
respectively


http://gerrit.cloudera.org:8080/#/c/10449/3/be/src/exec/plan-root-sink.h@106
PS3, Line 106:   /// State of the sender:
Producer instead of sender? Seems inconsistent with above.


http://gerrit.cloudera.org:8080/#/c/10449/3/be/src/exec/plan-root-sink.cc
File be/src/exec/plan-root-sink.cc:

http://gerrit.cloudera.org:8080/#/c/10449/3/be/src/exec/plan-root-sink.cc@116
PS3, Line 116: enounters
encounters



--
To view, visit http://gerrit.cloudera.org:8080/10449
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc75617a253fd43a6122baa4b4dc7aeb1dbe633f
Gerrit-Change-Number: 10449
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 May 2018 19:00:02 +0000
Gerrit-HasComments: Yes

Reply via email to