Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22101
to look at the new patch set (#2).
Change subject: PROTOTYPE: Add Calcite end-to-end tests
......................................................................
PROTOTYPE: Add Calcite end-to-end tests
This is a prototype for a few different improvements to
add Calcite testing:
1. It defines the USE_CALCITE_PLANNER environment variable
a. Setting USE_CALCITE_PLANNER=true causes start-impala-cluster.py
to start up using Calcite
b. IS_CALCITE_PLANNER detects the USE_CALCITE_PLANNER environment
variable and can be used to modify behavior in various places
2. It adds REQUIRED_PLANNER as a way to mark test sections that are
only compatible with one planner. It supports either CALCITE_PLANNER
or ORIGINAL_PLANNER.
2. It adds CALCITE_PLANNER_CATCH as a way to specify a Calcite-specific
error. This uses it in a couple places to try it out.
3. It adds CALCITE_PLANNER_EQUIVALENT_QUERY as a way to specify an
additional query to run against Calcite (expecting the same results
as the regular query). The test file parser produces two test
sections in this cae. First, it produces the regular test section
without CALCITE_PLANNER_EQUIVALENT_QUERY. Second, it produces the
extra Calcite section with the additional query. This is marked with
REQUIRED_PLANNER=CALCITE_PLANNER. This uses it in a couple places
to try it out.
4. This adds a "calcite_compatible" pytest marker and uses it to mark
TPC-H and TPC-DS tests.
5. IS_CALCITE_PLANNER=true causes tests/run-tests.py to require the
calcite_compatible marker unless --calcite_report_mode is set.
6. bin/run-all-tests.sh modfies the EE_TEST section to restart with
USE_CALCITE_PLANNER=true, run calcite compatible end to end tests,
then restart with the original USE_CALCITE_PLANNER value.
Change-Id: I87400a9bc602b6320c1625448874e76c6caad392
---
M bin/impala-config.sh
M bin/jenkins/dockerized-impala-run-tests.sh
M bin/run-all-tests.sh
M bin/start-impala-cluster.py
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java
M testdata/workloads/functional-query/queries/QueryTest/top-n.test
M testdata/workloads/functional-query/queries/QueryTest/union.test
M tests/common/environ.py
M tests/common/impala_test_suite.py
M tests/common/skip.py
M tests/pytest.ini
M tests/query_test/test_chars.py
M tests/query_test/test_tpcds_queries.py
M tests/query_test/test_tpch_queries.py
M tests/run-tests.py
M tests/util/test_file_parser.py
16 files changed, 150 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/22101/2
--
To view, visit http://gerrit.cloudera.org:8080/22101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87400a9bc602b6320c1625448874e76c6caad392
Gerrit-Change-Number: 22101
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
