Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22101 )

Change subject: PROTOTYPE: Add Calcite end-to-end tests
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22101/2/tests/query_test/test_tpch_queries.py
File tests/query_test/test_tpch_queries.py:

http://gerrit.cloudera.org:8080/#/c/22101/2/tests/query_test/test_tpch_queries.py@50
PS2, Line 50:     if IS_CALCITE_PLANNER:
            :       cls.ImpalaTestMatrix.add_constraint(lambda v:\
            :           v.get_value('table_format').file_format != 'kudu')
There is probably a cleaner / more general way to do this.



--
To view, visit http://gerrit.cloudera.org:8080/22101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87400a9bc602b6320c1625448874e76c6caad392
Gerrit-Change-Number: 22101
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Comment-Date: Mon, 25 Nov 2024 17:51:39 +0000
Gerrit-HasComments: Yes

Reply via email to