Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 28: (2 comments) > Patch Set 28: > > (8 comments) http://gerrit.cloudera.org:8080/#/c/20447/28/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20447/28/be/src/exprs/string-functions-ir.cc@1822 PS28, Line 1822: throw std::logic_error("AES only supports 128 and 256 bit key lengths."); > There could still be a mismatch between the chosen AES mode and the key len We're checking for the key length here, to make sure it is only from the lengths that we support. Why is it a mismatch? http://gerrit.cloudera.org:8080/#/c/20447/22/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/20447/22/be/src/util/openssl-util.cc@197 PS22, Line 197: void EncryptionKey::InitializeRandom(int key_len, int iv_len) { > It's true it's not new, I missed it. Can you please mention the tests that are failing. I'm using this to test the file and it seems to pass all the tests: ninja openssl-util-test && be/build/debug//util/openssl-util-test --gtest_filter="OpenSSLUtilTest.*". Also on another note, if these tests are unrelated to our patch, can I file them under a separate jira and cover them there? -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 28 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Wed, 27 Nov 2024 17:12:59 +0000 Gerrit-HasComments: Yes
