Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/10450 )
Change subject: IMPALA-6994: Avoid reloading a table's HMS data for file-only operations. ...................................................................... Patch Set 2: > > (2 comments) > > > > Just interested in this optimization. May I ask some questions? > > > > Looks like we are optimizing the case when partitionsToUpdate != > > null and partitions were neither dropped, created. Can we > optimize > > the case that partitionsToUpdate != null and some partitions are > > dropped? For example when an INSERT OVERWRITE statement updates > the > > majority of the partitions and only drops few of them. > > Will this case not introduce inconsistency between HMS and Impala? The problem with optimization is that introduces inconsistency, something which my change introduces too, when ALTER TABLE is done and HMS crashes. -- To view, visit http://gerrit.cloudera.org:8080/10450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaabdf38af3f30c65ada9734eb471dbfa6ecdd74a Gerrit-Change-Number: 10450 Gerrit-PatchSet: 2 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Sat, 19 May 2018 18:18:08 +0000 Gerrit-HasComments: No