Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10450 )
Change subject: IMPALA-6994: Avoid reloading a table's HMS data for file-only operations. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10450/2/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10450/2/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1410 PS2, Line 1410: partitionsToUpdateFileMdByPath = getPartitionsByPath(partitionsToUpdate); : loadMetadataAndDiskIds(partitionsToUpdateFileMdByPath, true); > The new change behaves very much like the old code except for the case when I don't think so. In line 1404, the dirtyPartitions are all added to partitionsToRemove. When dirtyPartitions exist, partitionsToRemove won't be empty. Thus the if-branch won't be chosen and the else-branch performs the same as the old codes. -- To view, visit http://gerrit.cloudera.org:8080/10450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaabdf38af3f30c65ada9734eb471dbfa6ecdd74a Gerrit-Change-Number: 10450 Gerrit-PatchSet: 2 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sun, 20 May 2018 01:27:25 +0000 Gerrit-HasComments: Yes
