Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21474 )
Change subject: IMPALA-13123: Add option to run tests with Python 3 ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/21474/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21474/10//COMMIT_MSG@9 PS10, Line 9: IMPALA_USE_PYTHON3_TESTS What happen if I run any tests under tests/shell/ with IMPALA_USE_PYTHON3_TESTS=True? Will it run with impala-python3 always? http://gerrit.cloudera.org:8080/#/c/21474/10//COMMIT_MSG@17 PS10, Line 17: - Eliminating 'basestring' and 'unicode' locations by using : the recommendations from future : ( https://python-future.org/compatible_idioms.html#basestring and : https://python-future.org/compatible_idioms.html#unicode ) What about occurrences in shell/ like this? https://github.com/apache/impala/blob/41c145f5add442dbd089bc77641c1e117486bc08/shell/compatibility.py#L42-L45 http://gerrit.cloudera.org:8080/#/c/21474/10/tests/run-tests.py File tests/run-tests.py: http://gerrit.cloudera.org:8080/#/c/21474/10/tests/run-tests.py@1 PS10, Line 1: #!/usr/bin/env impala-env-versioned-python I think start-impala-cluster.py should also run with impala-env-versioned-python. custom_cluster_test_suite.py call them as separate process? -- To view, visit http://gerrit.cloudera.org:8080/21474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I177d9b8eae9b99ba536ca5c598b07208c3887f8c Gerrit-Change-Number: 21474 Gerrit-PatchSet: 10 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 10 Dec 2024 23:58:07 +0000 Gerrit-HasComments: Yes
