Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21474 )
Change subject: IMPALA-13123: Add option to run tests with Python 3 ...................................................................... Patch Set 11: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/21474/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21474/10//COMMIT_MSG@9 PS10, Line 9: IMPALA_USE_PYTHON3_TESTS > Shell tests have two different pythons involved. There is the python used t Ack http://gerrit.cloudera.org:8080/#/c/21474/10//COMMIT_MSG@17 PS10, Line 17: - Eliminating 'basestring' and 'unicode' locations in tests/ by using : the recommendations from future : ( https://python-future.org/compatible_idioms.html#basestring and : https://python-future.org/compatible_idioms.html#unicode ) > shell/ already works properly with Python 3. It's uses of basestring and un Done http://gerrit.cloudera.org:8080/#/c/21474/10/tests/run-tests.py File tests/run-tests.py: http://gerrit.cloudera.org:8080/#/c/21474/10/tests/run-tests.py@1 PS10, Line 1: #!/usr/bin/env impala-env-versioned-python > Since these are running as separate scripts / separate processes, we have t Ack -- To view, visit http://gerrit.cloudera.org:8080/21474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I177d9b8eae9b99ba536ca5c598b07208c3887f8c Gerrit-Change-Number: 21474 Gerrit-PatchSet: 11 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 14 Dec 2024 00:48:26 +0000 Gerrit-HasComments: Yes
