Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries in frontend ...................................................................... Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/21803/19/tests/beeswax/impala_beeswax.py File tests/beeswax/impala_beeswax.py: http://gerrit.cloudera.org:8080/#/c/21803/19/tests/beeswax/impala_beeswax.py@a316 PS19, Line 316: > I think we still need to close_query unless the exception state is "Cancell I'm struggling with this. The logic in this client and impala-shell differ. I'm so far unable to prove or disprove that impala-shell will run into a similar issue where close_query fails and mask the cancelled message. I'm also struggling with where to address it. Should close/CloseOperation RPCs return successfully if the query is recognized but has already been unregistered? Or should the clients have to handle that case? I think ultimately this needs to be handled gracefully by clients, because if there's a delay between their last operation (which may have failed due to cancellation) and close (after the query is cancelled) they'll get an error anyway. -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 21 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 12 Dec 2024 01:04:32 +0000 Gerrit-HasComments: Yes
