Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21803 )

Change subject: IMPALA-915: Support cancel queries in frontend
......................................................................


Patch Set 17:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21803/17/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/21803/17/tests/webserver/test_web_pages.py@1013
PS17, Line 1013:     """Tests that we can cancel a query in the CREATED state 
while catalogd loads
I explored interrupting catalogd metadata loading for this case, but I don't 
think it makes sense. impalad sends prioritizeLoad to catalogd, which moves 
loading a table up the queue then handles loading that table asynchronously. I 
don't think it would make sense to interrupt that table load, especially if it 
was already in the queue.

The query is interrupted because impalad waits for a new catalog version, which 
seems sufficient.



--
To view, visit http://gerrit.cloudera.org:8080/21803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86
Gerrit-Change-Number: 21803
Gerrit-PatchSet: 17
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Thu, 21 Nov 2024 19:05:05 +0000
Gerrit-HasComments: Yes

Reply via email to