Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22210 )
Change subject: IMPALA-13603: Fix Flaky Live Queries Table Tests ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22210/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22210/2//COMMIT_MSG@9 PS2, Line 9: but does : not skip recording failed trivial DDLs > Does failed trivial DDL need to be recorded if the successful one is ignore It would be more consistent, but there isn't a way that I could find of determining if a QueryHandle instance represents a trivial DDL when the DDL failed. The backend would have to do string parsing on the query. http://gerrit.cloudera.org:8080/#/c/22210/2//COMMIT_MSG@11 PS2, Line 11: run a describe DDL in the setup_method() > This is even better: Does the existence of that catalog object guarantee it has been registered on all the coordinators too? -- To view, visit http://gerrit.cloudera.org:8080/22210 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I767a2bd7b068ab3fdeddb7cb3c4b307844d2d279 Gerrit-Change-Number: 22210 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 13 Dec 2024 23:47:51 +0000 Gerrit-HasComments: Yes
