Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22210 )
Change subject: IMPALA-13603: Fix Flaky Live Queries Table Tests ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/22210/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22210/2//COMMIT_MSG@9 PS2, Line 9: but does : not skip recording failed trivial DDLs > It would be more consistent, but there isn't a way that I could find of det Ack http://gerrit.cloudera.org:8080/#/c/22210/2//COMMIT_MSG@11 PS2, Line 11: run a describe DDL in the setup_method() > I like this approach better too. It requires much fewer code changes. Done http://gerrit.cloudera.org:8080/#/c/22210/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22210/4//COMMIT_MSG@19 PS4, Line 19: This change handles issues where the describe DDL in the : setup_method() fails by returning the number of times the describe : DDL ran and using that return to offset the expected record counts : in the test assertions. This needs edit explaining the alternative method. -- To view, visit http://gerrit.cloudera.org:8080/22210 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I767a2bd7b068ab3fdeddb7cb3c4b307844d2d279 Gerrit-Change-Number: 22210 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 14 Dec 2024 04:42:08 +0000 Gerrit-HasComments: Yes
