Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22235 )
Change subject: IMPALA-13622: Fix negative cardinality bug in AggregationNode.java ...................................................................... Patch Set 7: Code-Review+2 (2 comments) Thank you Jason and Csaba! Carry the +2 vote. http://gerrit.cloudera.org:8080/#/c/22235/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22235/6//COMMIT_MSG@18 PS6, Line 18: generalizes and replac > nit: generalizes/replaces Done http://gerrit.cloudera.org:8080/#/c/22235/6/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/22235/6/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@482 PS6, Line 482: // and aggInputCardinality is unknown. > nit: missing "is" Done -- To view, visit http://gerrit.cloudera.org:8080/22235 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib862a010b2094daa2cbdd5d555e46443009672ad Gerrit-Change-Number: 22235 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 20 Dec 2024 19:19:34 +0000 Gerrit-HasComments: Yes
