Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22235 )
Change subject: IMPALA-13622: Fix negative cardinality bug in AggregationNode.java ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/22235/8/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/22235/8/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@301 PS8, Line 301: Preconditions.checkState(numGroups <= aggInputCardinality_, : "numGroups (%s) is more than aggInputCardinality_ (%s)", numGroups, : aggInputCardinality_); Oops, this precondition is wrong. In case of non-grouping aggregation, numGroups = 1 and aggInputCardinality_ can be -1. I will remove this. -- To view, visit http://gerrit.cloudera.org:8080/22235 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib862a010b2094daa2cbdd5d555e46443009672ad Gerrit-Change-Number: 22235 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sat, 21 Dec 2024 01:35:37 +0000 Gerrit-HasComments: Yes
