Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/22134 )
Change subject: IMPALA-12992: Support for Hive JDBC Storage handler tables ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: > > > Patch Set 1: Verified-1 > > > > Build Failed > > > > https://jenkins.impala.io/job/gerrit-code-review-checks/11191/ : ABORTED > > Uploading a new patch soon, please ignore this one. http://gerrit.cloudera.org:8080/#/c/22134/1/fe/src/main/java/org/apache/impala/catalog/TableLoader.java File fe/src/main/java/org/apache/impala/catalog/TableLoader.java: http://gerrit.cloudera.org:8080/#/c/22134/1/fe/src/main/java/org/apache/impala/catalog/TableLoader.java@132 PS1, Line 132: /postgresql-jdbc.jar > Cannot hardcode driver path. Hi, I think you mean hive-site.xml. I think we're not hardcoding the driver path.To run our jdbc tasks, we need to run copy-ext-data-sources.sh where https://github.com/apache/impala/blob/2828e473710cc246dbdeb9e1da772c45881cfddb/testdata/bin/copy-ext-data-sources.sh#L44 path is defined. We're using the same and it will be same for all. All the other properties are extracted from the table properties stored in hms by hive. Note that this currently only works for postgresql. -- To view, visit http://gerrit.cloudera.org:8080/22134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1674b93a02f43df8c1a449cdc54053cc80d9c458 Gerrit-Change-Number: 22134 Gerrit-PatchSet: 1 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Sat, 21 Dec 2024 15:39:42 +0000 Gerrit-HasComments: Yes
