Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22134 )
Change subject: IMPALA-12992: Support for Hive JDBC Storage handler tables ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/22134/4/fe/src/main/java/org/apache/impala/catalog/TableLoader.java File fe/src/main/java/org/apache/impala/catalog/TableLoader.java: http://gerrit.cloudera.org:8080/#/c/22134/4/fe/src/main/java/org/apache/impala/catalog/TableLoader.java@130 PS4, Line 130: throw new TableLoadingException("Required parameter: hive.sql.database.type is missing."); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/22134/4/fe/src/main/java/org/apache/impala/catalog/TableLoader.java@134 PS4, Line 134: // impala_tbl_props.put("driver.url", "/test-warehouse/data-sources/jdbc-drivers/postgresql-jdbc.jar"); line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/22134/4/fe/src/main/java/org/apache/impala/catalog/TableLoader.java@137 PS4, Line 137: throw new TableLoadingException("Required parameter: hive.sql.dbcp.password is missing."); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/22134/4/fe/src/main/java/org/apache/impala/catalog/TableLoader.java@143 PS4, Line 143: throw new TableLoadingException("Required parameter: hive.sql.jdbc.url is missing."); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/22134/4/fe/src/main/java/org/apache/impala/catalog/TableLoader.java@149 PS4, Line 149: throw new TableLoadingException("Required parameter: hive.sql.dbcp.username is missing."); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/22134/4/fe/src/main/java/org/apache/impala/catalog/TableLoader.java@155 PS4, Line 155: throw new TableLoadingException("Required parameter: hive.sql.table is missing."); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22134/4/fe/src/main/java/org/apache/impala/catalog/TableLoader.java@161 PS4, Line 161: throw new TableLoadingException("Required parameter: hive.sql.jdbc.driver is missing."); line too long (98 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1674b93a02f43df8c1a449cdc54053cc80d9c458 Gerrit-Change-Number: 22134 Gerrit-PatchSet: 4 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 08 Jan 2025 06:00:15 +0000 Gerrit-HasComments: Yes
