Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22252 )
Change subject: WIP: refactor Frontend part 1 squished ...................................................................... Patch Set 5: (33 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/main/java/org/apache/impala/service/BETestJniFrontend.java File fe/src/main/java/org/apache/impala/service/BETestJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/main/java/org/apache/impala/service/BETestJniFrontend.java@258 PS5, Line 258: public TestTransactionContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java File fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java: http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java@251 PS5, Line 251: private AuthorizationFactory authzFactory_; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java@256 PS5, Line 256: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java@269 PS5, Line 269: public CoordinatorFrontendContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/main/java/org/apache/impala/service/FrontendContext.java File fe/src/main/java/org/apache/impala/service/FrontendContext.java: http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/main/java/org/apache/impala/service/FrontendContext.java@281 PS5, Line 281: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java File fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java: http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@646 PS5, Line 646: AnalysisResult analysisResult = analysisCtx.analyzeAndAuthorize(stmtBase, stmtTableCache, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@655 PS5, Line 655: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@694 PS5, Line 694: transaction_.createLockForInsert(txnId, tables, targetTable, insertStmt.isOverwrite(), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@732 PS5, Line 732: CopyTestCaseStmt testCaseStmt = (CopyTestCaseStmt) ((ParsedStatementImpl) parsedStmt).getStatementBase(); line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/main/java/org/apache/impala/stmtdriver/Transaction.java File fe/src/main/java/org/apache/impala/stmtdriver/Transaction.java: http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/main/java/org/apache/impala/stmtdriver/Transaction.java@251 PS5, Line 251: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/main/java/org/apache/impala/stmtdriver/TransactionContext.java File fe/src/main/java/org/apache/impala/stmtdriver/TransactionContext.java: http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/main/java/org/apache/impala/stmtdriver/TransactionContext.java@278 PS5, Line 278: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/analysis/AuditingTest.java File fe/src/test/java/org/apache/impala/analysis/AuditingTest.java: http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/analysis/AuditingTest.java@411 PS5, Line 411: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@276 PS5, Line 276: SelectStmt selectStmt = (SelectStmt) ((TestParsedStatement) parsedStmt).getStatementBase(); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@290 PS5, Line 290: SelectStmt selectStmt = (SelectStmt) ((TestParsedStatement) parsedStmt).getStatementBase(); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@303 PS5, Line 303: SelectStmt selectStmt = (SelectStmt) ((TestParsedStatement) parsedStmt).getStatementBase(); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@322 PS5, Line 322: SelectStmt selectStmt = (SelectStmt) ((TestParsedStatement) parsedStmt).getStatementBase(); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@352 PS5, Line 352: InsertStmt insertStmt = (InsertStmt) ((TestParsedStatement) parsedStmt).getStatementBase(); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@372 PS5, Line 372: CreateTableAsSelectStmt ctasStmt = (CreateTableAsSelectStmt) ((TestParsedStatement) parsedStmt).getStatementBase(); line too long (119 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1718 PS5, Line 1718: SelectStmt stmt = (SelectStmt) ((TestParsedStatement) parsedStmt).getStatementBase(); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1719 PS5, Line 1719: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java File fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java: http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@61 PS5, Line 61: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@79 PS5, Line 79: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@94 PS5, Line 94: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java: http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java@138 PS5, Line 138: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/common/FrontendFixture.java File fe/src/test/java/org/apache/impala/common/FrontendFixture.java: http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/common/FrontendFixture.java@382 PS5, Line 382: //XXX: fix this line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java File fe/src/test/java/org/apache/impala/common/FrontendTestBase.java: http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java@85 PS5, Line 85: protected static final Logger LOG = LoggerFactory.getLogger(FrontendTestBase.class.getName()); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java@358 PS5, Line 358: //XXX: fix this line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/common/QueryFixture.java File fe/src/test/java/org/apache/impala/common/QueryFixture.java: http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/common/QueryFixture.java@275 PS5, Line 275: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/common/QueryFixture.java@280 PS5, Line 280: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/common/TestParsedStatement.java File fe/src/test/java/org/apache/impala/common/TestParsedStatement.java: http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/common/TestParsedStatement.java@52 PS5, Line 52: protected static final Logger LOG = LoggerFactory.getLogger(TestParsedStatement.class.getName()); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/fe/src/test/java/org/apache/impala/common/TestParsedStatement.java@69 PS5, Line 69: stmt_ = Parser.parse(stmtSql); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/5/java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java File java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22252/5/java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java@88 PS5, Line 88: public TestTransactionContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/5/java/test-frontend/src/main/java/org/apache/impala/service/BETestJniFrontend.java File java/test-frontend/src/main/java/org/apache/impala/service/BETestJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22252/5/java/test-frontend/src/main/java/org/apache/impala/service/BETestJniFrontend.java@257 PS5, Line 257: public TestTransactionContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb8b54b8a2c36740bc6a10e8fec64dc70541327c Gerrit-Change-Number: 22252 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 23 Dec 2024 22:40:45 +0000 Gerrit-HasComments: Yes
