Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22252 )
Change subject: WIP: refactor Frontend part 1 ...................................................................... Patch Set 6: (40 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/analysis/AnalysisContextImpl.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContextImpl.java: http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/analysis/AnalysisContextImpl.java@64 PS6, Line 64: analysisResult_ = analysisWrapper_.analyzeAndAuthorize((StatementBase) parsedStmt_.getTopLevelNode(), line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/analysis/AnalysisContextImpl.java@85 PS6, Line 85: public Set<TAccessEvent> getAccessEvents() { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/service/BETestJniFrontend.java File fe/src/main/java/org/apache/impala/service/BETestJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/service/BETestJniFrontend.java@258 PS6, Line 258: public TestTransactionContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java File fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java: http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java@251 PS6, Line 251: private AuthorizationFactory authzFactory_; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java@256 PS6, Line 256: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/service/CoordinatorFrontendContextBuilder.java@269 PS6, Line 269: public CoordinatorFrontendContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/service/FrontendContext.java File fe/src/main/java/org/apache/impala/service/FrontendContext.java: http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/service/FrontendContext.java@281 PS6, Line 281: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java File fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java: http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@655 PS6, Line 655: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/stmtdriver/StmtDriver.java@694 PS6, Line 694: transaction_.createLockForInsert(txnId, tables, targetTable, insertStmt.isOverwrite(), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/stmtdriver/Transaction.java File fe/src/main/java/org/apache/impala/stmtdriver/Transaction.java: http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/stmtdriver/Transaction.java@251 PS6, Line 251: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/stmtdriver/TransactionContext.java File fe/src/main/java/org/apache/impala/stmtdriver/TransactionContext.java: http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/main/java/org/apache/impala/stmtdriver/TransactionContext.java@278 PS6, Line 278: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java: http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@2542 PS6, Line 2542: StatementBase stmtBase = (StatementBase) AnalyzesOk(String.format("select %s from functional.alltypes", repCols20), ctx); line too long (125 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@2570 PS6, Line 2570: stmtBase = (StatementBase) AnalyzesOk(String.format("select * from (select %s from functional.alltypes) x", line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@2577 PS6, Line 2577: stmtBase = (StatementBase) AnalyzesOk(String.format("with v as (select %s from functional.alltypes) " + line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@2592 PS6, Line 2592: stmtBase = (StatementBase) AnalyzesOk(String.format("with v as (select %s from functional.alltypes) select 1", line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@2613 PS6, Line 2613: stmtBase = (StatementBase) AnalyzesOk(String.format("select %s", literalList.toString()), ctx); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@2626 PS6, Line 2626: stmtBase = (StatementBase) AnalyzesOk("insert into functional.insert_overwrite_nopart (col1) VALUES " + line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@2637 PS6, Line 2637: stmtBase = (StatementBase) AnalyzesOk(String.format("select %s", constantExpr.toString()), ctx); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@2652 PS6, Line 2652: stmtBase = (StatementBase) AnalyzesOk(String.format("select int_col IN (%s) from functional.alltypes", line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/AuditingTest.java File fe/src/test/java/org/apache/impala/analysis/AuditingTest.java: http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/AuditingTest.java@411 PS6, Line 411: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java: http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@98 PS6, Line 98: analyzer_ = ((TestAnalysisContext) analysisCtx_).createAnalyzer(makeTableCache(parsedStmt)); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@372 PS6, Line 372: CreateTableAsSelectStmt ctasStmt = (CreateTableAsSelectStmt) parsedStmt.getTopLevelNode(); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1719 PS6, Line 1719: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java File fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java: http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@61 PS6, Line 61: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@79 PS6, Line 79: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@94 PS6, Line 94: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/TestAnalysisContext.java File fe/src/test/java/org/apache/impala/analysis/TestAnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/TestAnalysisContext.java@63 PS6, Line 63: public AnalysisResult analyzeAndAuthorize(ParsedStatement parsedStmt, StmtTableCache stmtTableCache, line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/TestAnalysisContext.java@66 PS6, Line 66: analysisResult_ = analysisWrapper_.analyzeAndAuthorize((StatementBase) parsedStmt.getTopLevelNode(), line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/analysis/TestAnalysisContext.java@91 PS6, Line 91: public Set<TAccessEvent> getAccessEvents() { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java: http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java@138 PS6, Line 138: TransactionContext.Builder transactionContextBuilder = new TransactionContext.Builder( line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/common/FrontendFixture.java File fe/src/test/java/org/apache/impala/common/FrontendFixture.java: http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/common/FrontendFixture.java@274 PS6, Line 274: QueryStmt viewStmt = (QueryStmt) parseStmt(createViewStmt.getInlineViewDef()).getTopLevelNode(); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/common/FrontendFixture.java@346 PS6, Line 346: AnalysisContext analysisCtx = new TestAnalysisContext(queryCtx, authzFactory, timeline); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/common/FrontendFixture.java@358 PS6, Line 358: AnalysisContext analysisCtx = new TestAnalysisContext(queryCtx, authzFactory, timeline); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/common/FrontendFixture.java@370 PS6, Line 370: AnalysisContext analysisCtx = new TestAnalysisContext(queryCtx, authzFactory, timeline); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java File fe/src/test/java/org/apache/impala/common/FrontendTestBase.java: http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java@85 PS6, Line 85: protected static final Logger LOG = LoggerFactory.getLogger(FrontendTestBase.class.getName()); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java@347 PS6, Line 347: return ctx.analyzeAndAuthorize(parsedStmt, stmtTableCache, fe.getAuthzChecker(), false); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/common/TestParsedStatement.java File fe/src/test/java/org/apache/impala/common/TestParsedStatement.java: http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/common/TestParsedStatement.java@54 PS6, Line 54: protected static final Logger LOG = LoggerFactory.getLogger(TestParsedStatement.class.getName()); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/fe/src/test/java/org/apache/impala/common/TestParsedStatement.java@71 PS6, Line 71: stmt_ = Parser.parse(stmtSql); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22252/6/java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java File java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22252/6/java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java@88 PS6, Line 88: public TestTransactionContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22252/6/java/test-frontend/src/main/java/org/apache/impala/service/BETestJniFrontend.java File java/test-frontend/src/main/java/org/apache/impala/service/BETestJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22252/6/java/test-frontend/src/main/java/org/apache/impala/service/BETestJniFrontend.java@257 PS6, Line 257: public TestTransactionContextBuilder(BackendConfig backendConfig) throws ImpalaException { line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb8b54b8a2c36740bc6a10e8fec64dc70541327c Gerrit-Change-Number: 22252 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 25 Dec 2024 05:51:32 +0000 Gerrit-HasComments: Yes
