Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22091 )
Change subject: IMPALA-13531: Calcite CTE frontend ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/22091/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/22091/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@117 PS7, Line 117: consumer.setProducer(producer); I think this could be cleaned up by adding Logical CTE nodes in runCTEProgram, then during runImpalaConvertProgram convert them to Physical CTE nodes. Convert would need to visit producers first, and register them in a map so consumers can be updated with a reference to the right RelNode subtree. -- To view, visit http://gerrit.cloudera.org:8080/22091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0840c0859d2fe25628d799a18d302cee1eb36e8 Gerrit-Change-Number: 22091 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 31 Dec 2024 19:25:36 +0000 Gerrit-HasComments: Yes
