Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22091 )
Change subject: IMPALA-13531: Calcite CTE frontend ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/22091/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22091/1//COMMIT_MSG@22 PS1, Line 22: different Suggester implementation. Defaults to the built-in > I'm working on turning this and some others into planner tests where we ver Done http://gerrit.cloudera.org:8080/#/c/22091/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/22091/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@291 PS1, Line 291: inputs.add(spoolPlan); > This should be smarter. ImpalaSequence nodes should be placed right above w Ack http://gerrit.cloudera.org:8080/#/c/22091/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/22091/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@348 PS2, Line 348: final List<N> results = new ArrayList<>(); > Still need to investigate. Done http://gerrit.cloudera.org:8080/#/c/22091/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/22091/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@373 PS4, Line 373: return; > This should be part of the parent patch. Done -- To view, visit http://gerrit.cloudera.org:8080/22091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0840c0859d2fe25628d799a18d302cee1eb36e8 Gerrit-Change-Number: 22091 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 26 Nov 2024 00:44:03 +0000 Gerrit-HasComments: Yes
