Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22036 )

Change subject: IMPALA-13518: Show target name of COMMIT_TXN events in logs
......................................................................


Patch Set 2:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22036/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
File 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java:

http://gerrit.cloudera.org:8080/#/c/22036/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@20
PS2, Line 20: import static 
org.apache.impala.catalog.events.MetastoreEvents.MetastoreEvent.CLUSTER_WIDE_TARGET;
line too long (98 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a7cb5e716453290866a4c3e74c0d269f621144f
Gerrit-Change-Number: 22036
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Fri, 03 Jan 2025 02:12:16 +0000
Gerrit-HasComments: Yes

Reply via email to