Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22036 )
Change subject: IMPALA-13518: Show target name of COMMIT_TXN events in logs ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22036/3/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/22036/3/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@853 PS3, Line 853: if (tableNames_.isEmpty()) return CLUSTER_WIDE_TARGET; > The transaction might change nothing then we will go here, e.g. OpenTxn() + I'm trying to understand how this class sees CLUSTER_WIDE_TARGET and compiles. -- To view, visit http://gerrit.cloudera.org:8080/22036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a7cb5e716453290866a4c3e74c0d269f621144f Gerrit-Change-Number: 22036 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Sat, 04 Jan 2025 00:13:44 +0000 Gerrit-HasComments: Yes
