Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22264 )
Change subject: IMPALA-13305: Better thrift compatibility checks based on pyparsing ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/22264/9/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/22264/9/bin/jenkins/critique-gerrit-review.py@270 PS9, Line 270: print(f"Removed struct {struct_name}") Should this get a warning? I guess if it was unused elsewhere, it's not an issue? http://gerrit.cloudera.org:8080/#/c/22264/9/bin/jenkins/thrift_parser.py File bin/jenkins/thrift_parser.py: http://gerrit.cloudera.org:8080/#/c/22264/9/bin/jenkins/thrift_parser.py@22 PS9, Line 22: # TODO: Consider using thriftpy2.parser. Need it to expose lineno. Why didn't you use it? Too many other dependencies? Also seems like you figured out lineno. -- To view, visit http://gerrit.cloudera.org:8080/22264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1dc4112404d0e7c5df94ee9f59a4fe2084b360d Gerrit-Change-Number: 22264 Gerrit-PatchSet: 9 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 03 Jan 2025 21:50:13 +0000 Gerrit-HasComments: Yes
