Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22264 )
Change subject: IMPALA-13305: Better thrift compatibility checks based on pyparsing ...................................................................... Patch Set 9: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/22264/8/bin/jenkins/thrift_parser.py File bin/jenkins/thrift_parser.py: http://gerrit.cloudera.org:8080/#/c/22264/8/bin/jenkins/thrift_parser.py@196 PS8, Line 196: structs = defaultdict() : enums = defaultdict() : for top_level_item in parse_results: : if top_level_item.getName() == 'struct': : # A dict from field id to thrift_parser.ThriftField : struct_fields = defaultdict() : for field in to > Yeah, it looks cleaner. Done http://gerrit.cloudera.org:8080/#/c/22264/9/bin/jenkins/thrift_parser.py File bin/jenkins/thrift_parser.py: http://gerrit.cloudera.org:8080/#/c/22264/9/bin/jenkins/thrift_parser.py@122 PS9, Line 122: optionalCommaOrSemi Just a thought, can you make this script report if there is a new field or enum item that ends with optional semicolon and let critique-gerrit-review.py WARN about that unnecessary semicolon? We are pretty inconsistent, especially in TQueryOptions. http://gerrit.cloudera.org:8080/#/c/22264/8/tests/infra/test_thrift_parser.py File tests/infra/test_thrift_parser.py: http://gerrit.cloudera.org:8080/#/c/22264/8/tests/infra/test_thrift_parser.py@30 PS8, Line 30: niversal > Good point! Done http://gerrit.cloudera.org:8080/#/c/22264/8/tests/infra/test_thrift_parser.py@34 PS8, Line 34: assert "TErrorCode" in out > The full output has 4k lines. Uploaded it in the JIRA: https://issues.apach thrift_parser_output.txt is helpful. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/22264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1dc4112404d0e7c5df94ee9f59a4fe2084b360d Gerrit-Change-Number: 22264 Gerrit-PatchSet: 9 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 04 Jan 2025 01:00:44 +0000 Gerrit-HasComments: Yes
