Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22032 )
Change subject: IMPALA-13086: Lower AggregationNode estimate using stats predicate ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/22032/11/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/22032/11/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@465 PS11, Line 465: boolean statsTupleAndConjuctsComputed = false; Was this an actual bug, or perf optimization? I'd prefer to clean up the conditional logic a bit to simplify this, like bool hasParquetFormat = hasParquet(fileFormats_); if ((hasParquetFormat && analyzer.getQueryOptions().parquet_read_statistics) || (hasOrc(fileFormats_) && analyzer.getQueryOptions().orc_read_statistics)) { computeStatsTupleAndConjuncts(analyzer); } if (hasParquetFormat && analyzer.getQueryOptions().parquet_dictionary_filtering) { computeDictionaryFilterConjuncts(analyzer); } -- To view, visit http://gerrit.cloudera.org:8080/22032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia840d68f1c4f126d4e928461ec5c44545dbf25f8 Gerrit-Change-Number: 22032 Gerrit-PatchSet: 11 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 03 Jan 2025 22:09:56 +0000 Gerrit-HasComments: Yes
