Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22032 )

Change subject: IMPALA-13086: Lower AggregationNode estimate using stats 
predicate
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22032/11/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:

http://gerrit.cloudera.org:8080/#/c/22032/11/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@465
PS11, Line 465:     boolean hasParquetFormat = hasParquet(fileFormats_);
> Was this an actual bug, or perf optimization?
It just perf change to avoid calling computeStatsTupleAndConjuncts twice.
Done.



--
To view, visit http://gerrit.cloudera.org:8080/22032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia840d68f1c4f126d4e928461ec5c44545dbf25f8
Gerrit-Change-Number: 22032
Gerrit-PatchSet: 12
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Sat, 04 Jan 2025 00:12:38 +0000
Gerrit-HasComments: Yes

Reply via email to