Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 )
Change subject: IMPALA-6953: clean up DiskIoMgr ...................................................................... Patch Set 7: Code-Review+1 (5 comments) I had already started looking earlier this morning. Looks generally like an improvement to me. Joe, if you want to do the review please do +2 otherwise I can do that. http://gerrit.cloudera.org:8080/#/c/10245/7/be/src/runtime/io/disk-io-mgr-internal.h File be/src/runtime/io/disk-io-mgr-internal.h: http://gerrit.cloudera.org:8080/#/c/10245/7/be/src/runtime/io/disk-io-mgr-internal.h@79 PS7, Line 79: / pre-existing nit: should only be // http://gerrit.cloudera.org:8080/#/c/10245/7/be/src/runtime/io/disk-io-mgr-internal.h@98 PS7, Line 98: extra space http://gerrit.cloudera.org:8080/#/c/10245/7/be/src/runtime/io/disk-io-mgr.h File be/src/runtime/io/disk-io-mgr.h: http://gerrit.cloudera.org:8080/#/c/10245/7/be/src/runtime/io/disk-io-mgr.h@395 PS7, Line 395: HandleWriteFinished () http://gerrit.cloudera.org:8080/#/c/10245/7/be/src/runtime/io/request-context.h File be/src/runtime/io/request-context.h: http://gerrit.cloudera.org:8080/#/c/10245/7/be/src/runtime/io/request-context.h@196 PS7, Line 196: gets get http://gerrit.cloudera.org:8080/#/c/10245/7/be/src/runtime/io/request-context.h@498 PS7, Line 498: inline void RequestContext::IncrementDiskThreadAfterDequeue(int disk_id) { > These functions got pulled out of the class body, but the logic shouldn't h I think this wrapper didn't exist in the old code. Is the PerDiskState completely hidden from outside the RequestContext? I guess not yet but maybe that's the direction you are going and so why you have this wrapper. -- To view, visit http://gerrit.cloudera.org:8080/10245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e393f8c01d10143cbac91108af37f6498c1b1 Gerrit-Change-Number: 10245 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 22 May 2018 17:59:56 +0000 Gerrit-HasComments: Yes
