Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 )
Change subject: IMPALA-6953: clean up DiskIoMgr ...................................................................... Patch Set 8: Code-Review+2 (1 comment) Looks good to me. The commit message could use a once-over for grammar. http://gerrit.cloudera.org:8080/#/c/10245/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10245/8//COMMIT_MSG@12 PS8, Line 12: Make DiskQueue is now an encapsulated class. Nit: grammar -- To view, visit http://gerrit.cloudera.org:8080/10245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e393f8c01d10143cbac91108af37f6498c1b1 Gerrit-Change-Number: 10245 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 22 May 2018 23:14:06 +0000 Gerrit-HasComments: Yes
