Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/22051 )
Change subject: IMPALA-13361: Add INSERT * and UPDATE SET * sytanx for MERGE statement ...................................................................... Patch Set 5: (5 comments) I changed the syntax from UPDATE * to UPDATE SET * to make it compatible with Spark. http://gerrit.cloudera.org:8080/#/c/22051/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22051/3//COMMIT_MSG@15 PS3, Line 15: count mismatches > Or the types mismatch. We could add tests that the actual column names don' Done http://gerrit.cloudera.org:8080/#/c/22051/3/fe/src/main/java/org/apache/impala/analysis/MergeUpdateStar.java File fe/src/main/java/org/apache/impala/analysis/MergeUpdateStar.java: http://gerrit.cloudera.org:8080/#/c/22051/3/fe/src/main/java/org/apache/impala/analysis/MergeUpdateStar.java@54 PS3, Line 54: gnmentExprs_.add(Pair.create(targetColu > nit: fits earlier line Done http://gerrit.cloudera.org:8080/#/c/22051/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/22051/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java@464 PS3, Line 464: es(s.id, s.u > Please add another test for the opposite case. Done http://gerrit.cloudera.org:8080/#/c/22051/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java@477 PS3, Line 477: then delete" > Please add another test for the opposite case. Done http://gerrit.cloudera.org:8080/#/c/22051/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java@477 PS3, Line 477: > There is no VALUES clause in the above MERGE statement Done -- To view, visit http://gerrit.cloudera.org:8080/22051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31cb771f2355ba4acb0f3b9f570ec44fdececdf3 Gerrit-Change-Number: 22051 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 07 Jan 2025 12:19:45 +0000 Gerrit-HasComments: Yes
