Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22051 )
Change subject: IMPALA-13361: Add INSERT * and UPDATE SET * sytanx for MERGE statement ...................................................................... Patch Set 5: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/22051/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22051/5//COMMIT_MSG@7 PS5, Line 7: sytanx typo http://gerrit.cloudera.org:8080/#/c/22051/5//COMMIT_MSG@21 PS5, Line 21: E2E test modified to use * syntax when it's possible Is it still true? http://gerrit.cloudera.org:8080/#/c/22051/3/fe/src/main/java/org/apache/impala/analysis/MergeUpdateStar.java File fe/src/main/java/org/apache/impala/analysis/MergeUpdateStar.java: http://gerrit.cloudera.org:8080/#/c/22051/3/fe/src/main/java/org/apache/impala/analysis/MergeUpdateStar.java@64 PS3, Line 64: : > I think toSql() at the end would be also useful for complex MERGE statement Seems like it is resolved. -- To view, visit http://gerrit.cloudera.org:8080/22051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31cb771f2355ba4acb0f3b9f570ec44fdececdf3 Gerrit-Change-Number: 22051 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 07 Jan 2025 13:31:52 +0000 Gerrit-HasComments: Yes
