Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode ...................................................................... Patch Set 9: (7 comments) http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@210 PS4, Line 210: options, args = parser.parse_args() > This appears to be unused. It's true that most of the time we use_local_cat Done http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@266 PS4, Line 266: processes = [proc for _, proc in find_user_processes(binary_names)] > nit: Unnecessary whitespace. Done http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@361 PS4, Line 361: else: > nit: Unnecessary whitespace. Done http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@448 PS4, Line 448: if remap_ports: > I think this could be simpler. Handle it the same as other options below: Done http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@685 PS4, Line 685: > catalog_topic_mode only needs to be set on catalogd. We still need to set `-use_local_catalog` here. http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@688 PS4, Line 688: """If the cluster is kerberized, returns arguments to pass to daemon process. > If not set, don't specify an option. Tests still set this via impalad_args. Done http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@719 PS4, Line 719: # > I don't understand what this is doing. Done -- To view, visit http://gerrit.cloudera.org:8080/21443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142 Gerrit-Change-Number: 21443 Gerrit-PatchSet: 9 Gerrit-Owner: Anshula Jain <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 10 Jan 2025 00:29:58 +0000 Gerrit-HasComments: Yes
