Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode ...................................................................... Patch Set 15: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/21443/12/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/21443/12/bin/start-impala-cluster.py@207 PS12, Line 207: "catalogd and cache it locally. The cached metadata gets evicted" > I don't think we generally use this short-hand in our help messages. Done http://gerrit.cloudera.org:8080/#/c/21443/12/bin/start-impala-cluster.py@678 PS12, Line 678: # Appended at the end so they can override previous args. > I think my point is not getting across completely. Done http://gerrit.cloudera.org:8080/#/c/21443/13/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/21443/13/bin/start-impala-cluster.py@682 PS13, Line 682: > nit: extra whitespace should be removed. It's fine to keep the newline, jus Done -- To view, visit http://gerrit.cloudera.org:8080/21443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142 Gerrit-Change-Number: 21443 Gerrit-PatchSet: 15 Gerrit-Owner: Anshula Jain <[email protected]> Gerrit-Reviewer: Anshula Jain <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 05 Feb 2025 18:42:55 +0000 Gerrit-HasComments: Yes
