Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22047 )
Change subject: IMPALA-2945: Account for duplicate keys on multiple nodes preAgg ...................................................................... Patch Set 15: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22047/14/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/22047/14/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@920 PS14, Line 920: urceProfile.noReservation(0); > Done That seems to better reflect the cardinality changes in memory estimates. http://gerrit.cloudera.org:8080/#/c/22047/15/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/22047/15/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@348 PS15, Line 348: aggClassOutputCardinality_.add(aggOutputCard); nit: if we're not using estimatePreaggDuplicate, this uses additional memory for no benifit. -- To view, visit http://gerrit.cloudera.org:8080/22047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04c563e59421928875b340cb91654b9d4bc80b55 Gerrit-Change-Number: 22047 Gerrit-PatchSet: 15 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 10 Jan 2025 21:39:01 +0000 Gerrit-HasComments: Yes
