Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22047 )
Change subject: IMPALA-2945: Account for duplicate keys on multiple nodes preAgg ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/22047/15/testdata/workloads/functional-planner/queries/PlannerTest/processing-cost-plan-admission-slots.test File testdata/workloads/functional-planner/queries/PlannerTest/processing-cost-plan-admission-slots.test: http://gerrit.cloudera.org:8080/#/c/22047/15/testdata/workloads/functional-planner/queries/PlannerTest/processing-cost-plan-admission-slots.test@102 PS15, Line 102: 2.30K > Ideally, the right value for this should have been closer to NDV * num_inst 384 is from 128 instances * 3 nodes. The 128 comes from MAX_FRAGMENT_INSTANCES_PER_NODE constant. https://github.com/apache/impala/blob/71818c673ba446c1f6a37a8181a74de02c09f7db/common/thrift/Query.thrift#L141-L143 This constant is the default value of query option MAX_FRAGMENT_INSTANCES_PER_NODE. https://github.com/apache/impala/blob/71818c673ba446c1f6a37a8181a74de02c09f7db/common/thrift/Query.thrift#L671-L672 I will set lower option value for this test in future patch. -- To view, visit http://gerrit.cloudera.org:8080/22047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04c563e59421928875b340cb91654b9d4bc80b55 Gerrit-Change-Number: 22047 Gerrit-PatchSet: 15 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2025 19:40:46 +0000 Gerrit-HasComments: Yes
