Yida Wu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22130 )

Change subject: IMPALA-13565: Add general AI platform support to 
ai_generate_text
......................................................................


Patch Set 6:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/22130/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22130/4//COMMIT_MSG@18
PS4, Line 18: auth_credential to support passing both plain text and jceks
> maybe rephrase this to
Done


http://gerrit.cloudera.org:8080/#/c/22130/4//COMMIT_MSG@23
PS4, Line 23: tions, with
> Should we rename this to something more generic like "credential_type"? The
Done


http://gerrit.cloudera.org:8080/#/c/22130/4/be/src/exprs/ai-functions.h
File be/src/exprs/ai-functions.h:

http://gerrit.cloudera.org:8080/#/c/22130/4/be/src/exprs/ai-functions.h@73
PS4, Line 73:   /// credential and optional platform params.
> We should probably update comments to explain difference between 'params' a
Done


http://gerrit.cloudera.org:8080/#/c/22130/4/be/src/udf/udf.h
File be/src/udf/udf.h:

http://gerrit.cloudera.org:8080/#/c/22130/4/be/src/udf/udf.h@80
PS4, Line 80:   /// Same as ai_generate_text but also adds impala_options as a 
parameter.
> We're adding a new built in function? Shouldn't we just extend the existing
I think the function pointer can't share the same name as the previous one, 
like the UdaUpdate2 in line 420, but the exposed interface is still 
ai_generate_text.



--
To view, visit http://gerrit.cloudera.org:8080/22130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ea2e1946089f262dda7ace73d5f7e37a5c98b14
Gerrit-Change-Number: 22130
Gerrit-PatchSet: 6
Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com>
Gerrit-Comment-Date: Mon, 13 Jan 2025 02:28:17 +0000
Gerrit-HasComments: Yes

Reply via email to